Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgres connector: ignore unique constraint violations from IF NOT EXISTS #942

Merged
merged 1 commit into from
Dec 30, 2023
Merged

postgres connector: ignore unique constraint violations from IF NOT EXISTS #942

merged 1 commit into from
Dec 30, 2023

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Dec 30, 2023 •
edited
Loading

Followup from #905 now that I've seen parallel testing of pg connector (#941) running into this

@serprex
postgres connector: ignore unique constraint violations from IF NOT E…
e185c82 
…XISTS

Followup from #905 now that I've seen parallel testing of pg connector running into this
@serprex serprex force-pushed the more-is-unique-ignoring branch from f0a68cd to e185c82 Compare December 30, 2023 16:11
@serprex serprex changed the title More is unique ignoring postgres connector: ignore unique constraint violations from IF NOT EXISTS Dec 30, 2023
@serprex serprex merged commit a182a23 into main Dec 30, 2023
7 checks passed
@serprex serprex mentioned this pull request Dec 30, 2023
Merged
serprex added a commit that referenced this pull request Dec 31, 2023
@serprex
Don't create metadata schema in a transaction (#943)
c6e284e 
When a command errors during a transaction the transaction can no longer progress, it must be rolled back
This is the case when IF NOT EXISTS errors over unique violation

We do not need schema/table creation to be transactional, so remove transaction

Corrects #942 & #905 to be effective
@serprex serprex deleted the more-is-unique-ignoring branch January 4, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskakaushik iskakaushik iskakaushik approved these changes

@Amogh-Bharadwaj Amogh-Bharadwaj Awaiting requested review from Amogh-Bharadwaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serprex @iskakaushik