Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: add tables as unique rows #935

Merged
merged 2 commits into from
Dec 29, 2023
Merged

UI: add tables as unique rows #935

merged 2 commits into from
Dec 29, 2023

Conversation

Amogh-Bharadwaj
Copy link
Contributor

Removes the business of checking if we've expanded a schema and then inserting rows or not
Simpler: uses lodash functions to attain a unique array of objects while inserting table rows on schema expand

@serprex
Copy link
Contributor

serprex commented Dec 29, 2023

Use lodash-es instead so that tree shaking can reduce bundle size impact

Copy link
Contributor

@serprex serprex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more efficient algo should be used

@Amogh-Bharadwaj Amogh-Bharadwaj merged commit c67f605 into main Dec 29, 2023
10 checks passed
@serprex serprex deleted the ui/assert-unique-rows branch July 19, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants