BQ merge: don't be transactional #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussed with Kevin BQ lock contention. He made #889 to remove temp table Merge is idempotent, so no need to have transaction, which removes need to have advisory lock on catalog
serprex
force-pushed
the
remove-bq-lock
branch
from
33ff7a4 to
5e9ae02
Compare
|
LGTM, but deferring to @iskakaushik in case we want the metadata update to be done in a txn as well |
heavycrystal
approved these changes
Dec 25, 2023
iskakaushik
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed with Kevin BQ lock contention. He made #889 to remove temp table
Merge is idempotent, so no need to have transaction, which removes need to have advisory lock on catalog