Show alerts in UI #883
Merged
Show alerts in UI #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iskakaushik
commented
Dec 22, 2023
•
iskakaushik
commented
serprex
reviewed
Dec 22, 2023
Amogh-Bharadwaj
force-pushed
the
alerts-in-ui
branch
from
f665fdf to
db3b18e
Compare
Amogh-Bharadwaj
approved these changes
Dec 22, 2023
iskakaushik
added a commit
that referenced
this pull request
Dec 25, 2023
## UI Improvement Features These are some features which I thought would be nice to get in. At the end of the day, these are just proposals from my end. ### Mirror Create Pages: Error Toasts And Floating Button We now show errors as toasts and have the Create Mirror button with a fixed position on the bottom-right. Users now don't have to do a lot of scrolling up and down to look at the error message, come back, and click create. <img width="1461" alt="Screenshot 2023-12-23 at 10 26 14 PM" src="https://github.com/PeerDB-io/peerdb/assets/65964360/a21c2b23-bddc-4c56-91df-962f02b64589"> ### QRep Mirror: Upsert Columns Selection of Unique Key Columns for QRep Upsert mode now looks like this, saving users from having to type out columns. Also added validation for the columns being an empty array. <img width="1461" alt="Screenshot 2023-12-23 at 9 49 35 PM" src="https://github.com/PeerDB-io/peerdb/assets/65964360/42b6beb9-afb9-44aa-a55f-8973958ec30f"> ### Better Tabs UI for Mirror Overview I thought the tabs we have there look unpolished so used Tremor to come up with this. This also achieves significant code reduction in that file. <img width="1726" alt="Screenshot 2023-12-23 at 11 37 58 PM" src="https://github.com/PeerDB-io/peerdb/assets/65964360/23b623ec-82c0-4df4-9e9d-32560a6c0d91"> ### Wiring Status in Mirror Overview Page Wires in the Status we show in the mirror overview page. This is a follow-up to #883 <img width="601" alt="Screenshot 2023-12-23 at 10 28 23 PM" src="https://github.com/PeerDB-io/peerdb/assets/65964360/9fe08a47-c774-496b-8417-02a27fcee034"> ### Others - Removes 'Authentication failed' message in login landing page. - Makes the source-destination table list in Mirror Overview page have scrollable height and sticky headers - Error table now has time column before message column and the rows are sorted by timestamp (latest first) --------- Co-authored-by: Kaushik Iska <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.