Remove direct dependency on pkcs1/pkcs8 #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
remove-pkcs1
branch
from
46f2e57 to
2d21b65
Compare
serprex
changed the title
Amogh-Bharadwaj
approved these changes
Dec 19, 2023
serprex
force-pushed
the
remove-pkcs1
branch
from
0524748 to
1240542
Compare
serprex
force-pushed
the
remove-pkcs1
branch
from
1240542 to
cf88f2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made while attempting to remove pkcs1 to get around https://people.redhat.com/~hkario/marvin
Unfortunately this'll require changing keys. So I'll look to implement support for pkcs8 encoded keys too so pkcs1 can be avoided