Remove multierror to fix error in error handling #832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
serprex
force-pushed
the
no-errors-in-json
branch
2 times, most recently
from
19b18e5 to
b41d6fe
Compare
multierror struct has a formatting closure, making it unserializable Thus, multierror cannot be stored in temporal state Replace with jsonerr, with fallback logic for non serializable errors
serprex
force-pushed
the
no-errors-in-json
branch
from
b41d6fe to
808d48f
Compare
iskakaushik
approved these changes
Dec 16, 2023
|
This is probably overkill, simpler would be to store errors as Rendered: #833 |
|
Closing in favor of #833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multierror struct has a formatting closure, making it unserializable
Thus, multierror cannot be stored in temporal state
Replace with jsonerr, with fallback logic for non serializable errors