postgres cdc: update mirror lsn_offset when wal processing raises consumedXLogPos #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
start-lsn-investigation
branch
2 times, most recently
from
ed66fc7 to
fceefb1
Compare
…sumedXLogPos Not doing so could cause failures if consumption restarted, since retrieval of mirror lsn_offset would start before updated lsn sent to pg, making possible that pg had gotten rid of that wal in meantime
serprex
force-pushed
the
start-lsn-investigation
branch
from
fceefb1 to
313c708
Compare
serprex
force-pushed
the
start-lsn-investigation
branch
from
a4a4d61 to
9c73c0f
Compare
serprex
force-pushed
the
start-lsn-investigation
branch
from
9c73c0f to
68bf3ce
Compare
serprex
commented
Dec 14, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
iskakaushik
reviewed
Dec 14, 2023
iskakaushik
reviewed
Dec 14, 2023
Log how much heartbeat adjusts lsn, don't call SetLastOffset if lsn hasn't moved
iskakaushik
reviewed
Dec 14, 2023
serprex
force-pushed
the
start-lsn-investigation
branch
from
9641287 to
065e205
Compare
iskakaushik
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not doing so could cause failures if consumption restarted, since retrieval of mirror lsn_offset would start before updated lsn sent to pg, making possible that pg had gotten rid of that wal in meantime
Also always use
GREATESTto make sure lsn_offset is monotonic