Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add throttling when there is a syncErr #2356

Merged
merged 1 commit into from
Dec 13, 2024
Merged

add throttling when there is a syncErr #2356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion flow/workflows/sync_flow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func SyncFlowWorkflow(
}

syncFlowCtx := workflow.WithActivityOptions(syncSessionCtx, workflow.ActivityOptions{
StartToCloseTimeout: 72 * time.Hour,
StartToCloseTimeout: 7 * 24 * time.Hour,
HeartbeatTimeout: time.Minute,
WaitForCancellation: true,
})
Expand Down Expand Up @@ -162,6 +162,15 @@ func SyncFlowWorkflow(
}

restart := syncErr || workflow.GetInfo(ctx).GetContinueAsNewSuggested()

if syncErr {
logger.Info("sync flow error, sleeping for 30 seconds...")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to log, already logged error when syncErr was set

err := workflow.Sleep(ctx, 30*time.Second)
if err != nil {
logger.Error("failed to sleep", slog.Any("error", err))
}
}

if !stop && !syncErr && mustWait {
waitSelector.Select(ctx)
if restart {
Expand Down
Loading