Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support tls_cert/tls_key in nexus #2355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

support tls_cert/tls_key in nexus #2355

wants to merge 1 commit into from

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Dec 13, 2024

Need to contribute upstream to pgwire:

  1. tokio-rustls should be reexported since we must use same version of TlsAcceptor as them
  2. feature should not add parameter to public facing api method, as adding features should never break code

@serprex
Copy link
Contributor Author

serprex commented Dec 13, 2024

sunng87/pgwire#228

@serprex serprex marked this pull request as ready for review December 19, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

@iamKunalGupta iamKunalGupta Awaiting requested review from iamKunalGupta

@heavycrystal heavycrystal Awaiting requested review from heavycrystal

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@serprex