[cdc] treat all pkms as reply_requested #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
Dec 12, 2024
serprex
approved these changes
Dec 12, 2024
heavycrystal
force-pushed
the
pkm-always-replyrequested
branch
from
281adf2 to
0e6d9ed
Compare
|
@heavycrystal can you do a large cdc update test on this once? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at walsender code,
PrimaryKeepaliveMessagesare mostly only sent withreply_requestedwhenwal_sender_timeoutis non-zero. We recommendwal_sender_timeoutbe set to 0. We currently only send aStandbyStatusMessagewhen we see a pkm that hasreply_requestedso we almost never send them.Treat all pkms as
reply_requestedfor hopefully more aggressive slot flushes.