Wrap get current LSN in txn as pgx will retry #2284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per jackc/pgx#74 (comment) moving reads into a transaction will initiate retries on network-level errors.
serprex
approved these changes
Nov 24, 2024
serprex
reviewed
Nov 24, 2024
| if ctx.Err() != nil { | ||
| return ctx.Err() | ||
| } | ||
| time.Sleep(retryDelay) |
There was a problem hiding this comment.
this will give an extra sleep on last try
serprex
reviewed
Nov 24, 2024
| var lsnString string | ||
| if err := tx.QueryRow(ctx, query).Scan(&lsnString); err != nil { | ||
| return 0, fmt.Errorf("query failed: %w", err) | ||
| if err := fn(tx); err != nil { |
There was a problem hiding this comment.
I don't think this accomplishes what you want still, you need to reconnect on net errors. Since retry logic of pgx exists in the pooling code
At that point there's no benefit to starting read only transaction since we aren't dealing with pooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per jackc/pgx#74 (comment) moving reads into a transaction will initiate retries on network-level errors.