Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable wal heartbeats by default #2217

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Enable wal heartbeats by default #2217

merged 2 commits into from
Nov 14, 2024

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Nov 4, 2024

users predating PG14 should change the query or disable wal heartbeats

@serprex serprex force-pushed the send-blind-status-update branch from 60a4e21 to 610a4fd Compare November 4, 2024 21:12
Copy link
Member

@iamKunalGupta iamKunalGupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's test and merge

@iamKunalGupta iamKunalGupta linked an issue Nov 4, 2024 that may be closed by this pull request
@serprex serprex force-pushed the send-blind-status-update branch 2 times, most recently from 130ded6 to f2bc172 Compare November 4, 2024 21:47
@serprex
Copy link
Contributor Author

serprex commented Nov 4, 2024

Sending updated LSN & logging that updated LSN. PG is ignoring when we send unrequested standby status updates with updated LSN

@serprex serprex marked this pull request as draft November 5, 2024 13:36
@iamKunalGupta
Copy link
Member

@serprex do we need to send WalFlushPosition instead for RDS?

@iamKunalGupta
Copy link
Member

@serprex do we need to send WalFlushPosition instead for RDS?

nvm, the library does it for us

@serprex serprex force-pushed the send-blind-status-update branch from f2bc172 to 22e1cdc Compare November 14, 2024 13:25
@serprex serprex changed the title Send standby status once a minute Enable wal heartbeats by default Nov 14, 2024
@serprex serprex marked this pull request as ready for review November 14, 2024 13:26
@serprex serprex enabled auto-merge (squash) November 14, 2024 13:26
@serprex serprex merged commit 350686f into main Nov 14, 2024
7 checks passed
@serprex serprex deleted the send-blind-status-update branch November 14, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable heartbeats by default
3 participants