improve logs pagination #2202
Merged
improve logs pagination #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
improve-logs-pagination
branch
from
9dfab61 to
eeb6814
Compare
iskakaushik
reviewed
Oct 29, 2024
serprex
force-pushed
the
improve-logs-pagination
branch
2 times, most recently
from
c194617 to
ac07420
Compare
using LIMIT/OFFSET is inaccurate when new logs come it while logs being viewed this makes a minor improvement by instead being based on records before/after an id from previous page, which is how I'd like to also add pagination to sync batches in mirror status
serprex
force-pushed
the
improve-logs-pagination
branch
from
ac07420 to
46b81ea
Compare
pjhampton
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using LIMIT/OFFSET is inaccurate when new logs come it while logs being viewed
this makes a minor improvement by instead being based on records before/after an id from previous page,
which is how I'd like to also add pagination to sync batches in mirror status