no peer config stored in temporal state #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
approved these changes
Jun 15, 2024
heavycrystal
requested changes
Jun 16, 2024
serprex
commented
Jun 16, 2024
serprex
force-pushed
the
no-tempo-peer-config
branch
from
1b6aa51 to
8c44128
Compare
serprex
force-pushed
the
no-tempo-peer-config
branch
from
640396c to
01989fb
Compare
serprex
commented
Jun 18, 2024
serprex
force-pushed
the
no-tempo-peer-config
branch
5 times, most recently
from
611f940 to
cd95157
Compare
serprex
force-pushed
the
no-tempo-peer-config
branch
from
735ef78 to
c2e4231
Compare
that'll be harder, since e2e relies on passing peer configs not in catalog
…d call instead of tests themselves
Now to actually make it work
…ds, upgrade logic
1. pause mirrors 2. upgrade to 0.14 3. resume mirrors, pause mirrors 4. upgrade to 0.15 protobuf doesn't encode default values, so can remove fields for 0.15 other deprecated fields removed as they should be out of the way with mirrors being paused
… listing mirrors. Fix drop mirror request & typing
serprex
force-pushed
the
no-tempo-peer-config
branch
from
8c0ff58 to
348758f
Compare
iskakaushik
approved these changes
Jun 21, 2024
heavycrystal
approved these changes
Jun 22, 2024
| SELECT name, type, options | ||
| FROM peers | ||
| WHERE name = $1`, peerName) | ||
| // TODO remove in 0.15 |
There was a problem hiding this comment.
don't remove, could be used for handling config changes from UI
There was a problem hiding this comment.
must not be called from temporal, UI endpoints must update directly, so should not be in activity code
| @@ -33,14 +33,6 @@ type SnapshotFlowExecution struct { | |||
| tableNameSchemaMapping map[string]*protos.TableSchema | |||
| } | |||
|
|
|||
| type cloneTablesInput struct { | |||
There was a problem hiding this comment.
had implemented it because getting arguments mixed around is quite possible with this call
serprex
added a commit
that referenced
this pull request
Jun 22, 2024
needed before 0.14 so upgrade protocol can be performed for #1844
Ideally we'd handle base64/hex instead of binary strings, but this does the bad thing faster
serprex
force-pushed
the
no-tempo-peer-config
branch
from
e82e66e to
6b4072d
Compare
serprex
force-pushed
the
no-tempo-peer-config
branch
from
66a5310 to
d4c020b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also api uses peer names more too instead of passing configs around
This will need two version bumps to sanitize: