Clickhouse: Fix setting of normalize batch ID #1836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
approved these changes
Jun 14, 2024
serprex
approved these changes
Jun 14, 2024
|
Subset of #1837 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of NormalizeRecords in Clickhouse, we were updating the normalize batch ID in metadata with
normBatchID + 1.Clickhouse's NormalizeRecords (like postgres) normalizes from normBatchID to syncBatchId. Hence we should update the normalize batch id in metadata to sync batch ID, not normbatchID + 1. This is also what the other destinations do
This PR fixes this batch id setting and also adds a warning log for normbatchid >= syncbatchid