Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack alerts : can now specify members to tag in the channel #1832

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

Amogh-Bharadwaj
Copy link
Contributor

@Amogh-Bharadwaj Amogh-Bharadwaj commented Jun 13, 2024

Adds a Members field in UI where you can add comma separated slack usernames to tag in the channel. If left empty, tags the whole channel
Also adds a guide to slack alerting in the alerts UI

Functionally tested:
Screenshot 2024-06-14 at 2 00 40 AM

ui/app/alert-config/new.tsx Outdated Show resolved Hide resolved
flow/alerting/slack_alert_sender.go Outdated Show resolved Hide resolved
@heavycrystal
Copy link
Contributor

why can't we just make a new channel with the members they want?

@serprex
Copy link
Contributor

serprex commented Jun 13, 2024

why can't we just make a new channel with the members they want?

not convenient for all scenarios, eg can configure this to ping on call

@Amogh-Bharadwaj Amogh-Bharadwaj merged commit 71b414f into main Jun 17, 2024
11 checks passed
@Amogh-Bharadwaj Amogh-Bharadwaj deleted the slack-alerts-members branch June 17, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants