Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spill to disk based on flow-worker memory usage #1231

Merged
merged 2 commits into from
Feb 9, 2024
Merged

spill to disk based on flow-worker memory usage #1231

merged 2 commits into from
Feb 9, 2024

Conversation

heavycrystal
Copy link
Contributor

the existing number of records based threshold is still present, both can be active at the same time.

Best used with GOMEMLIMIT to keep heap more aligned with set memory limit.

iamKunalGupta
iamKunalGupta reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@iamKunalGupta iamKunalGupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small naming changes, rest looks good

flow/peerdbenv/config.go Outdated Show resolved Hide resolved
flow/connectors/utils/cdc_records/cdc_records_storage.go Outdated Show resolved Hide resolved
@heavycrystal heavycrystal merged commit 094b69d into main Feb 9, 2024
7 checks passed
@heavycrystal heavycrystal deleted the cdc-records-mem-threshold branch February 9, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamKunalGupta iamKunalGupta iamKunalGupta approved these changes

@serprex serprex Awaiting requested review from serprex

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heavycrystal @iamKunalGupta