BigQuery cross project support: unqualify tables for cdc/qrep #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amogh-Bharadwaj
force-pushed
the
bigquery/fix-cross-support
branch
from
fdfe8db to
5e18a79
Compare
iskakaushik
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultDatasetIDandDefaultProjectIDwork only for unqualified tables. This PR unqualifies our tables in bigquery queries for qrep and cdc.Will update our docs to explicitly say that we support cross-project mode only for CDC and QRep (BQ). This is yet to be integrated for resync mirror
This PR has been functionally tested with two projects.
Follow up to #1073