Turn on most gocritic lints (#1217)

flow/.golangci.yml

@@ -40,8 +40,22 @@ linters-settings:
       - 'prefix(github.com/PeerDB-io)'
       - default
   gocritic:
+    enabled-tags:
+      - diagnostic
+      - experimental
+      - opinionated
+      - performance
+      - style
     disabled-checks:
       - ifElseChain
+      - importShadow
+      - paramTypeCombine
+      - sprintfQuotedString
+      - unnamedResult
+      - whyNoLint
+    settings:
+      hugeParam:
+        sizeThreshold: 512
   stylecheck:
     checks:
       - all

flow/cmd/mirror_status.go

@@ -343,7 +343,7 @@ func (h *FlowRequestHandler) isCDCFlow(ctx context.Context, flowJobName string)
 		return false, fmt.Errorf("unable to query flow: %w", err)
 	}
 
-	if !query.Valid || len(query.String) == 0 {
+	if !query.Valid || query.String == "" {
 		return true, nil
 	}
 

flow/cmd/validate_peer.go

@@ -21,7 +21,7 @@ func (h *FlowRequestHandler) ValidatePeer(
 		}, nil
 	}
 
-	if len(req.Peer.Name) == 0 {
+	if req.Peer.Name == "" {
 		return &protos.ValidatePeerResponse{
 			Status:  protos.ValidatePeerStatus_INVALID,
 			Message: "no peer name provided",

flow/connectors/clickhouse/normalize.go

@@ -149,9 +149,6 @@ func (c *ClickhouseConnector) NormalizeRecords(req *model.NormalizeRecordsReques
 			ct := column.Type
 
 			colSelector.WriteString(fmt.Sprintf("%s,", cn))
-			// if i < numCols-1 {
-			// 	colSelector.WriteString(",")
-			// }
 
 			extractionFuction := "JSONExtractRaw"
 			switch qvalue.QValueKind(ct) {

flow/connectors/postgres/qrep_partition_test.go

@@ -63,8 +63,6 @@ func newTestCaseForCTID(schema string, name string, rows uint32, expectedNum int
 }
 
 func TestGetQRepPartitions(t *testing.T) {
-	// log.SetLevel(log.DebugLevel)
-
 	const connStr = "postgres://postgres:postgres@localhost:7132/postgres"
 
 	// Setup the DB
@@ -222,23 +220,18 @@ func prepareTestData(t *testing.T, pool *pgx.Conn, schema string) int {
 
 	// Define the start and end times
 	startTime := time.Date(2010, time.January, 1, 10, 0, 0, 0, time.UTC)
-	endTime := time.Date(2010, time.January, 30, 10, 0, 0, 0, time.UTC)
-
-	// Prepare the time range
-	var times []time.Time
-	for t := startTime; !t.After(endTime); t = t.Add(24 * time.Hour) {
-		times = append(times, t)
-	}
+	endTime := time.Date(2010, time.January, 31, 10, 0, 0, 0, time.UTC)
 
-	// Insert the test data
-	for i, time := range times {
+	times := 0
+	for tm := startTime; tm.Before(endTime); tm = tm.Add(24 * time.Hour) {
+		times += 1
 		_, err := pool.Exec(context.Background(), fmt.Sprintf(`
 			INSERT INTO %s.test (value, "from") VALUES ($1, $2)
-		`, schema), i+1, time)
+		`, schema), times, tm)
 		if err != nil {
 			t.Fatalf("Failed to insert test data: %v", err)
 		}
 	}
 
-	return len(times)
+	return times
 }

flow/connectors/postgres/qvalue_convert.go

@@ -496,7 +496,6 @@ func parseFieldFromQValueKind(qvalueKind qvalue.QValueKind, value interface{}) (
 			Value: fmt.Sprintf("POINT(%f %f)", xCoord, yCoord),
 		}
 	default:
-		// log.Warnf("unhandled QValueKind => %v, parsing as string", qvalueKind)
 		textVal, ok := value.(string)
 		if !ok {
 			return qvalue.QValue{}, fmt.Errorf("failed to parse value %v into QValueKind %v", value, qvalueKind)

flow/workflows/qrep_flow.go

@@ -468,12 +468,12 @@ func QRepFlowWorkflow(
 	}
 
 	logger.Info("partitions to replicate - ", len(partitions.Partitions))
-	if err = q.processPartitions(ctx, maxParallelWorkers, partitions.Partitions); err != nil {
+	if err := q.processPartitions(ctx, maxParallelWorkers, partitions.Partitions); err != nil {
 		return err
 	}
 
 	logger.Info("consolidating partitions for peer flow - ", slog.String("flowName", config.FlowJobName))
-	if err = q.consolidatePartitions(ctx); err != nil {
+	if err := q.consolidatePartitions(ctx); err != nil {
 		return err
 	}
 

flow/workflows/xmin_flow.go

@@ -68,7 +68,7 @@ func XminFlowWorkflow(
 		return fmt.Errorf("xmin replication failed: %w", err)
 	}
 
-	if err = q.consolidatePartitions(ctx); err != nil {
+	if err := q.consolidatePartitions(ctx); err != nil {
 		return err
 	}