Skip to content

Commit

Permalink
ci: only run BQ on pg16 & SF on pg17 (#2379)
Browse files Browse the repository at this point in the history
BQ was being more flaky after matrix added. Limit concurrency on external services
  • Loading branch information
serprex authored Dec 19, 2024
1 parent f931bc0 commit 61cd7db
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/flow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,4 @@ jobs:
PEERDB_CATALOG_DATABASE: postgres
PEERDB_QUEUE_FORCE_TOPIC_CREATION: "true"
ELASTICSEARCH_TEST_ADDRESS: http://localhost:9200
CI_PG_VERSION: ${{ matrix.postgres-version }}
3 changes: 1 addition & 2 deletions flow/e2e/bigquery/bigquery.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@ func SetupSuite(t *testing.T) PeerFlowE2ETestSuiteBQ {
t.Fatalf("Failed to create helper: %v", err)
}

err = bqHelper.RecreateDataset()
if err != nil {
if err := bqHelper.RecreateDataset(); err != nil {
t.Fatalf("Failed to recreate dataset: %v", err)
}

Expand Down
5 changes: 5 additions & 0 deletions flow/e2e/bigquery/peer_flow_bq_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"errors"
"fmt"
"os"
"testing"
"time"

Expand All @@ -20,6 +21,10 @@ import (
)

func TestPeerFlowE2ETestSuiteBQ(t *testing.T) {
if val, ok := os.LookupEnv("CI_PG_VERSION"); ok && val != "16" {
t.Skip("Only running in PG16 to reduce flakiness from high concurrency")
}

e2eshared.RunSuite(t, SetupSuite)
}

Expand Down
5 changes: 5 additions & 0 deletions flow/e2e/snowflake/peer_flow_sf_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package e2e_snowflake
import (
"context"
"fmt"
"os"
"testing"
"time"

Expand All @@ -17,6 +18,10 @@ import (
)

func TestPeerFlowE2ETestSuiteSF(t *testing.T) {
if val, ok := os.LookupEnv("CI_PG_VERSION"); ok && val != "17" {
t.Skip("Only running in PG17 to reduce flakiness from high concurrency")
}

e2eshared.RunSuite(t, SetupSuite)
}

Expand Down

0 comments on commit 61cd7db

Please sign in to comment.