-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinguished Name implementation #314
Open
rviau42
wants to merge
9
commits into
PeculiarVentures:master
Choose a base branch
from
rviau42:feature/dn-improvment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing Distinguished name according to RFC5280 and X.501
microshine
requested changes
May 3, 2021
rviau42
force-pushed
the
feature/dn-improvment
branch
from
May 7, 2021 08:53
336cb58
to
3ea742d
Compare
microshine
reviewed
May 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rviau42 Thanks. Update looks good. All tests are successfully passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the structure change, this Pull Request can introduce breaking changes
Distinguished Name implementation
Add DistinguishedName class which contains a collection of RelativeDistinguishedName
according to RFC5280 and X.501.
Subject and Issuer properties in Certificate, CRL, OCSP, ... classes doesn't accept Array anymore but Array.
Instead of:
You must declare these fields with:
DN toString()
For debugging purpose or more, it could be useful to get a string representation of DNs.
DistinguishedName.toString()
prodives a String representation of DN almost conformed to RFC4514To achieve to this conversion, there is a new Map containing the most common OID used for DN, based on RFC4519(https://tools.ietf.org/html/rfc4519):
AttributeTypeDictionnary
The 57 OID described in section #2 AttributeType and section #3 ObjectClass are retrieved.