Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

add chat warning delay option #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PabloDinella
Copy link

I felt motivated to study a little bit of c++ with this project (I'm a web dev), so I tried to implement and propose a simple enhancement, which was already mentioned on #187 and #70.

The result is this option on Settings > Moderation:

image

Min value is 20 seconds, since below that is too spammy IMO, and max is 60.

There's something I didn't manage to change though: here we need to replace CHEATER_WARNING_INTERVAL with m_Settings->GetChatWarningInterval(), but I don't know how to use m_Settings here...

		// We also need to remove this in favor of m_Settings->GetChatWarningInterval()
		static constexpr duration_t CHEATER_WARNING_INTERVAL = std::chrono::seconds(20);

		// The soonest we can make an accusation after having seen an accusation in chat from a bot leader.
		// This must be longer than CHEATER_WARNING_INTERVAL.
		static constexpr duration_t CHEATER_WARNING_INTERVAL_NONLOCAL = CHEATER_WARNING_INTERVAL + std::chrono::seconds(10);

@ClusterConsultant ClusterConsultant added Priority: Medium This issue may be useful, and needs some attention. Status: Review Needed The issue has a PR attached to it which needs to be reviewed. Type: Enhancement New feature or request labels Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Review Needed The issue has a PR attached to it which needs to be reviewed. Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants