Better defined RPC and HTTP errors #482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses HTTP and RPC status codes from Bitcoin Corrects inconsistencies between RPC error codes
|
Parts of this may not match bitcoin in regards to the thrown type (runtime_error vs an actual error number (example, multisig)); this is because a runtime_error is really inappropriate for an RPC error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses HTTP and RPC status codes from Bitcoin
Corrects inconsistencies between RPC error codes
There are a few instances instances where I was unsure whether the used error code was really valid so I commented it. In some cases error codes were changed because of inconsistencies or because of the use of the wrong error code in the first place.
This will need extensive review because of changed codes, unfortunately this may create issues for Paycoin RPC wallet implementations but should also bring some consistency between Paycoin and Bitcoin to better allow Bitcoin RPC software to work with Paycoin
(3 hours 30 minutes)