Remove spent transactions from minting table #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MitchellCash needs rebase |
MitchellCash
force-pushed
the
minting_table
branch
from
62f2c2b to
1726180
Compare
|
@IngCr3at1on rebased |
|
I've been playing with this on the testnet today (for quite awhile) and it doesn't seem to crash like my original attempt at this. Having said that the crashing was always inconsistent in Linux, @CeForce this will need to be tested on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #466 and is another attempt at removing spent transactions from the minting table.
This is meant for vigorous testing before merge so we avoid the same mistakes of the past.
Would love a lot of eyes over this.