Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save main-geometry and some header data before closing the GUI #458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Save main-geometry and some header data before closing the GUI #458

wants to merge 1 commit into from

Conversation

IngCr3at1on
Copy link
Contributor

This will restore the physical geometry of the main window upon reopening

It will also retain and restore the column header sizes for the minting
tab and the transactions tab; do to the nature of the address book (in
that both receiving page and the address book page use the same header
object) we cannot restore this without breaking scrape address display
(I figure this is safe cause there's only 2 or 3 entries on both those
tabs and they fit pretty well in all states).

This resolves #308

This will restore the physical geometry of the main window upon reopening

It will also retain and restore the column header sizes for the minting
tab and the transactions tab; do to the nature of the address book (in
that both receiving page and the address book page use the same header
object) we cannot restore this without breaking scrape address display
(I figure this is safe cause there's only 2 or 3 entries on both those
tabs and they fit pretty well in all states).

This resolves #308
@IngCr3at1on
Copy link
Contributor Author

6.42 hours

@MitchellCash
Copy link
Contributor

I've been looking into this more and agree we should have the ability to save the main-geometry for the main GUI.

But I don't think we need to burden ourselves with saving the different column widths but I do think the columns (well the Minting Table Model) needs to work in a way that everything is visible to the user.

If we define the minimum width of the column and that minimum width shows everything visible then lets not bother saving the column width.

So my thoughts to make this happen is a change to the Minting Table Model in which we remove the Transaction column and implement the ability to double click on the transaction to open a more detailed transaction description (like in the Transaction Table).

We then make the Address column use QHeaderView::Stretch, reduce the MintProbability column to 120.

This should leave enough space on the Minting Table Model for everything to be viewable even on a reduced window. If the power user wishes for more detail than the behaviour should match the Transaction Table and they double click for more info.

@IngCr3at1on
Copy link
Contributor Author

@MitchellCash saving the tab states for all but the address book is trivial and already included in this commit. I see little reason not to save the tab states if we can (convenience factor and it's literally just 1 extra line in the qt generated conf file).

I'm all for adjusting the defaults but I see absolutely no reason to remove saving the tab states from this commit.

@MitchellCash
Copy link
Contributor

Agreed as this commit stands to allow saving adjustable column widths.

So my thinking was on a higher level to what the root cause to this was, if we make it so the whole Minting Table is viewable on Paycoin startup than there is no need to adjust columns.

And also some UX came into play which was matching the Minting tab to the Transaction tab in how it functioned.

@IngCr3at1on
Copy link
Contributor Author

@MitchellCash there may not be a need but at the same time if someone uses the wallet in a different size than the default it should be adjustable imho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retain geometry/state when closing/opening qt wallet
2 participants