Refactor primenodedb interaction #442
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the primenode/microprime database handling to function more like the wallet database (less overhead).
Caught by linter
|
@MitchellCash when you get a chance I'd appreciate if you could test this. |
|
I have confirmed PrimeNode staking is functioning as per usual. I am waiting for the MicroPrime fix and hard fork to confirm that. |
|
@MitchellCash if primenodes are working than that's enough to confirm the database is working properly. This just changes the logic substantially. |
|
I need this so I can avoiding rewriting a bunch of other stuff later. Will be merging shortly. As stated if Primenodes are working with this change then so will anything else related to that database. |
|
Sounds okay to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the primenode/microprime database handling to function more like
the wallet database (less overhead).
Includes some general cleanup as well
(4.67 hours)