Change display logic for transaction table and scrape transactions #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All scrape transactions display the address that the reward went to. "External scrape" type is set on transactions where the staking address is not found in the receiving wallet. "Local scrape" type is set on transactions where the staking address and reward/scrape address are both found in the same wallet. "Scraped to external" type is set on transactions where the reward address was not found in the same wallet that did the stake In the case of such transactions the reward coins are never present in the staking wallet and therefore are always displayed in brackets.
|
This addresses #210 (3 hours 10 minutes) |
|
Added a commit to reduce some repeat code (15 minutes) |
|
@MitchellCash and @CeForce it would be good to get some testing on this so we can merge it as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All scrape transactions display the address that the reward went to.
"External scrape" type is set on transactions where the staking address
is not found in the receiving wallet.
"Local scrape" type is set on transactions where the staking address
and reward/scrape address are both found in the same wallet.
"Scraped to external" type is set on transactions where the reward
address was not found in the same wallet that did the stake
In the case of such transactions the reward coins are never present in
the staking wallet and therefore are always displayed in brackets.