Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ior.cyg with lustre explicit support #404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ior.cyg with lustre explicit support #404

wants to merge 1 commit into from

Conversation

akmchew
Copy link
Contributor

@akmchew akmchew commented Oct 8, 2020

  • Modified version of existing ior.cyh with lustre support

@akmchew
ior.cyg with lustre explicit support
8cea9e8 
* Modified version of existing ior.cyh with lustre support
marcodelapierre
marcodelapierre reviewed Oct 8, 2020
View reviewed changes
Copy link
Contributor

@marcodelapierre marcodelapierre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment,
as you're setting the configure flags in the build function explicitly, you may get rid of line 33 defining MAALI_TOOL_CONFIGURE
Otherwise good to go!

@akmchew
Copy link
Contributor Author

akmchew commented Oct 8, 2020

Just having a look why it was originally written that way, looks like it was modified to include MVAPICH post.

Hold the merge I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcodelapierre marcodelapierre marcodelapierre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akmchew @marcodelapierre