Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for Mac OS HID access #19

Closed
wants to merge 1 commit into from
Closed

Patch for Mac OS HID access #19

wants to merge 1 commit into from

Conversation

rixtox
Copy link

@rixtox rixtox commented Jan 5, 2016

These lines will cause HID access problems when compile with libusb.
It's better to comment out these lines as default.

@PaulStoffregen
Copy link
Owner

Could you please add a comment about which version(s) of OS-X this has been verified to work?

@rixtox
Copy link
Author

rixtox commented Jan 5, 2016

With OS=LINUX and this patch applied. It's verified working on OS X 10.11.2 (El Capitan) and previous 10.10 (Yosemite) and 10.9 (Mavericks).

@PaulStoffregen
Copy link
Owner

Oh, I see. I only looked at the changes and didn't see you put this in the Linux section.

I can't merge a change that breaks things for Linux. This needs to be done in a way where Mac users can configure it for Macs.

Is this really even necessary? Is the Mac version of the code not working on El Capitan?

@rixtox
Copy link
Author

rixtox commented Jan 5, 2016

No, I believe they are not working at all.

@PaulStoffregen
Copy link
Owner

I hope you can understand why I can't merge a change that breaks Linux.

@rixtox
Copy link
Author

rixtox commented Jan 6, 2016

I surely understand that.
This is just a workaround for Mac OS X if someone want to use it.
You can just leave it closed for the record. I will submit a temporary patch on Homebrew, and wait for any progress from upstream. Is that okay?

@PaulStoffregen
Copy link
Owner

I believe the proper solution is to fix the OS-X native code. Using the Linux code on Mac with this patch is a ugly hack. If anyone wants to use this hack, they certainly can. I'm even willing to add another build type to the makefile. But I can't merge any patch that breaks support for Linux users.

@rixtox
Copy link
Author

rixtox commented Jan 6, 2016

Yes, you don't need to merge it at all. It's just a quick and dirty workaround.
Close this issue and make a TODO will work for you.
I just want to have a working Hombrew formula and that's all.

@PaulStoffregen
Copy link
Owner

merged by #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants