-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch for Mac OS HID access #19
Conversation
Could you please add a comment about which version(s) of OS-X this has been verified to work? |
With |
Oh, I see. I only looked at the changes and didn't see you put this in the Linux section. I can't merge a change that breaks things for Linux. This needs to be done in a way where Mac users can configure it for Macs. Is this really even necessary? Is the Mac version of the code not working on El Capitan? |
No, I believe they are not working at all. |
I hope you can understand why I can't merge a change that breaks Linux. |
I surely understand that. |
I believe the proper solution is to fix the OS-X native code. Using the Linux code on Mac with this patch is a ugly hack. If anyone wants to use this hack, they certainly can. I'm even willing to add another build type to the makefile. But I can't merge any patch that breaks support for Linux users. |
Yes, you don't need to merge it at all. It's just a quick and dirty workaround. |
merged by #20 |
These lines will cause HID access problems when compile with libusb.
It's better to comment out these lines as default.