Updating third party docs page to include npm packages and products #6920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the Setup project always fails
johnsimons
force-pushed
the
john/thrid
branch
from
9a52ddf to
92e3a84
Compare
johnsimons
force-pushed
the
john/thrid
branch
from
3d17219 to
299c396
Compare
johnsimons
force-pushed
the
john/thrid
branch
from
256bb64 to
3e4cd77
Compare
|
@PhilBastian I am not 100% sure whether the title of the page should still be "Thrid-party licenses", thoughts? |
|
I will update the licenses text to the new URL once this is merged |
|
@udidahan we need some advice here. Should we mention all the 3rd party libraries as a "Credit to these 3rd party" ? Has this a legal implication? |
udidahan
requested changes
Dec 11, 2024
Co-authored-by: Udi Dahan <[email protected]>
Co-authored-by: Udi Dahan <[email protected]>
I have added a redirect, and will also update all locations found in this search once this is live. |
|
OK, so while I can't say that I've reviewed all the other elements on this PR, I do approve the current state of the third-party-licenses.md file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all the scripts to generate the 3rd party list to also include ServiceControl and ServicePulse.
The 3rd party list moves from
/nservicebus/upgrades/third-party-licensesto/platform/third-party-licenses.As part of this change we also improved the diff viewing when the changes are large, now we create a
changes.patchartifact that is easier to review and apply manually.This also changes the layout of the page, the page changes to a simple list of all 3rd party libs that are used for all Particular software: