Usage Tracking: Only log messages when tracking is enabled #3748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I would approach this very differently: I'd move all the logging inside the usage tracking module, rather than expose more usage tracking internals outwards into the DFK. (the DFK historically knows too much stuff -- https://en.wikipedia.org/wiki/God_object -- and I'm slowly chipping away at that over the years) |
benclifford
approved these changes
Jan 20, 2025
|
@yadudoc @khk-globus you might be interested in this test failure (which i'm going to ignore as it's not a required test pass here) https://github.com/Parsl/parsl/actions/runs/12867506582/job/35872290547?pr=3748#step:8:48 |
benclifford
changed the title
|
@NishchayKarle i trimmed the title for this PR a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug where the DFK logs that it is entering usage tracking code in a way that suggests it is logging usage tracking data, even when turned off.
Changed Behaviour
The DFK will only log messages about usage tracking data being sent when usage tracking is enabled.
Fixes
Fixes #3740
Type of change