-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a deploy action #85
Create a deploy action #85
Conversation
DO we need to merge in order to see if it works ? |
Yes in order to see the website, however we can check beforehand that the action completed successfully. |
.github/workflows/doc-build.yml
Outdated
with: | ||
name: doc | ||
name: DocHTML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to be explicit about the format as sphinx can compile to various forms + it's consistent with other repos in Parietal-INRIA / mind-inria.
Refactored the |
Thanks, @pbarbarant ! When checks are green I'm good to merge 🚀 I already set up the redirect from https://parietal-inria.github.io/fmralign-docs and archived that repo, so I think this should be the end of our deployment issues ! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good. Need to wait for CI to complete.
Co-authored-by: Elizabeth DuPre <[email protected]>
Co-authored-by: Elizabeth DuPre <[email protected]>
Co-authored-by: Elizabeth DuPre <[email protected]>
Closes #91 |
This is now the same error we saw before merging in 7dbab07 , so I think it's ready to go and I'm happy to see this in ! |
Okay I'm merging it! |
Updates various gh actions and implements automatic deployment of the docs on a gh-pages branch.