forked from gzigzigzeo/sidekiq-grouping
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync upstream #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix mistype: elasic -> elastic
Add gem version badge to Readme
…tion Fixes sidekiq deprecation
Optimized Lua script for Redis >= 6.2.0
…nterface-for-inline-mode pass args to worker as array in inline mode
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Lint and clean
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
Signed-off-by: Valentin Kiselev <[email protected]>
…upto-7 Support sidekiq upto 7
…raisal does not support yet
Sync upstream 2
A port of this commit which changes were originaly omitted from a recent merge conflict resolution. d82e1a0 The existing code loads all redis scripts during application load however that means we're waiting for requests to finish during application load which creates latency and potentially errors in boostrapping. Rather, we use the same mechanism from this other commit to lazy load redis scripts once and only once in a thread safe manner, so they are loaded once needed and not again.
Prevent loading scripts multiple times per process
rex-remind101
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
justinhoward
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the upstream changes into our fork and fixes rubocop issues introduced in the reliable batches changes.