Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[added] build workflow #2

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thekaushikls
Copy link

@thekaushikls thekaushikls commented May 2, 2023

  1. Added a Github Action to automatically build and release plugin when Version number is changed in .csproj file.
  2. Added PostBuild script to load plugin when building locally.
  3. Added launchSettings.json to run _-Grasshopper command when builiding locally.

name: release_ci

on:
push: # Runs on push to main branch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of running this on all push and schedule, it's probably better to run only when a new release is specified:

on:
  release:
    types: [published]

this would also allow for changes to the version number during dev without accidentally creating a release.
this would also minimize action and minute usages

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lin-ycv thanks for the suggestion. I was assuming the main branch will be protected, and contributors will only raise pull request. Which means, only admins can trigger this workflow.

Also, since the version information is taken from the .csproj file, it would be easier to just update the version number directly from VisualStudio.

If you suggest that it is comfortable to update in all places (Brain.csproj and the GitHub release tag), it can be done. In that case, do you think having a workflow_dispatch is better? (Example Below)

Reference: basecamp

@thekaushikls thekaushikls marked this pull request as draft July 19, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants