fix recursion limit triggering in hiero blasts #28038
Open
+52
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR fixes an issue where the hierophant blast would trigger BYOND's recursion limit due to simple mobs dropping mob spawners, which in the process of generating their organs, would trigger the hierophant blast on the same tile. Note that this wasn't actually an infinite loop, but a deeply nested call stack which caused BYOND to barf.
Why It's Good For The Game
Better logic.
Testing
Yeah
Declaration
Changelog
NPFC