Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier banning of DC'd players. #28032

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

FunnyMan3595
Copy link
Contributor

What Does This PR Do

Changes the ban process from Player Panel to rely on last_known_ckey instead of ckey, so that banning (including jobbanning) a disconnected player doesn't rely on manual bans.

Why It's Good For The Game

Better admin tooling is good.

Testing

Jobbanned myself from one of each category of ban.
Jobbanned myself from each ban category entire.
Banned myself. (It bailed out at the last second, but still kicked me.)
Banned a volunteer (thank you, Ratcliffe!) both while they were online and after they'd been kicked for the first ban.
Jobbanned the same volunteer after they were gone.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

@FunnyMan3595 FunnyMan3595 added Administration This PR relates to ingame administration features Tweak This PR tweaks something ingame labels Jan 19, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Administration This PR relates to ingame administration features Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants