Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handheld EFTPOS offering #27978

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

FunnyMan3595
Copy link
Contributor

@FunnyMan3595 FunnyMan3595 commented Jan 14, 2025

What Does This PR Do

Lets you hold out the handheld EFTPOS to request a payment. Anyone in a range of two tiles can use their ID to swipe through the EFTPOS.

Why It's Good For The Game

Using a handheld EFTPOS is awkward. Either you have to hand it to them, or they have to hand their ID to you. Either way, someone could run off with an object the other wants to keep. Being able to hold onto it and have someone else use their ID on you is much nicer.

Images of changes

image
image

Testing

Completed a transaction in-hand.
Completed a transaction by clicking myself.
Completed a transaction by clicking an adjacent person.
Completed a transaction by clicking someone two tiles away.
No result when clicking someone three tiles away.
Was told to use an ID when clicking someone adjacent or two tiles away without the ID in hand.
Was told I had insufficient funds.
Was told the ID didn't have an account linked.
Offered the EFTPOS by using *payme.
Offered the EFTPOS by clicking the button in its UI.
Tried to use *payme without locking the EFTPOS.
Tried to use *payme without an EFTPOS in hand.
Tried to scan an ID card after the person with the EFTPOS dropped it.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Handheld EFTPOS devices can now be offered out for anyone within 2 tiles to swipe their card through, either by clicking the UI button or by using the emote *payme. The other person just needs to click on you with their ID in hand.
/:cl:

@FunnyMan3595 FunnyMan3595 added Feature This PR is a new addition to the game TGUI This PR modifies TGUI, will conflict labels Jan 14, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 14, 2025
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jan 15, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 16, 2025
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Jan 19, 2025
Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a few things here with visible messages, regarding how they will be sorted.

code/modules/economy/economy_machinery/eftpos.dm Outdated Show resolved Hide resolved
code/modules/economy/economy_machinery/eftpos.dm Outdated Show resolved Hide resolved
code/modules/economy/economy_machinery/eftpos.dm Outdated Show resolved Hide resolved
code/modules/economy/economy_machinery/eftpos.dm Outdated Show resolved Hide resolved
code/modules/economy/economy_machinery/eftpos.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/human_emote.dm Outdated Show resolved Hide resolved
Co-authored-by: Burzah <[email protected]>
Signed-off-by: Charlie Nolan <[email protected]>
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 23, 2025
@Burzah Burzah added this pull request to the merge queue Jan 24, 2025
Merged via the queue into ParadiseSS13:master with commit a809609 Jan 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Feature This PR is a new addition to the game TGUI This PR modifies TGUI, will conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants