Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Dynamic" Gamemode using rulesets #27600

Merged
merged 20 commits into from
Jan 19, 2025
Merged

"Dynamic" Gamemode using rulesets #27600

merged 20 commits into from
Jan 19, 2025

Conversation

Contrabang
Copy link
Contributor

@Contrabang Contrabang commented Dec 9, 2024 •
edited
Loading

This is not TG's dynamic gamemode.

What Does This PR Do

Adds a new gamemode: Dynamic. Like trifecta, but can spawn all, some, or no antags. Replaces all traitor, vampire, changeling, and (partially) extended gamemodes, except trifecta. Read the design doc here: #27599

This will fix #27786

Why It's Good For The Game

Its a huge improvement to the code, and will allow for easier additions and restrictions of gamemode code.

Testing

Not yet tested, I want to view CI and get more feedback before continuing.

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Adds a new gamemode: Dynamic. Like trifecta, but can spawn all, some, or no antags.
del: Replaces most gamemodes with traitors, vampires, and changelings with Dynamic.
/:cl:

@Contrabang Contrabang marked this pull request as draft December 9, 2024 23:40
@Contrabang Contrabang changed the title Dynamic "Dynamic" Gamemode using rulesets Dec 9, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Configuration Change This PR changes the game configuration files. Please run via the host. labels Dec 10, 2024
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Dec 10, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added Testmerge Requested This PR has a pending testmerge request -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Dec 10, 2024
@Contrabang Contrabang marked this pull request as ready for review December 22, 2024 22:16
@Burzah Burzah removed the Merge Conflict This PR is merge conflicted label Dec 22, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label Dec 23, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot removed the Testmerge Active This PR is currently testmerged on production label Dec 23, 2024
warriorstar-orion
warriorstar-orion suggested changes Dec 23, 2024
View reviewed changes
code/game/gamemodes/dynamic/antag_rulesets.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/antag_rulesets.dm Show resolved Hide resolved
code/game/gamemodes/dynamic/antag_rulesets.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/antag_rulesets.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/antag_rulesets.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/antag_rulesets.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/antag_rulesets.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/antag_rulesets.dm Outdated Show resolved Hide resolved
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Dec 28, 2024
warriorstar-orion
warriorstar-orion approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@warriorstar-orion warriorstar-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

code/game/gamemodes/dynamic/antag_rulesets.dm Outdated Show resolved Hide resolved
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 2, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label Jan 3, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot removed the Testmerge Active This PR is currently testmerged on production label Jan 4, 2025
AffectedArc07
AffectedArc07 approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved CFG change - please page me before merge omfg

@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label Jan 13, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot removed the Testmerge Active This PR is currently testmerged on production label Jan 14, 2025
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jan 16, 2025
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Jan 19, 2025
@AffectedArc07 AffectedArc07 added this pull request to the merge queue Jan 19, 2025
Merged via the queue into ParadiseSS13:master with commit 8954a8e Jan 19, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crazyhair213 Crazyhair213 Crazyhair213 left review comments

@lewcc lewcc lewcc left review comments

@Burzah Burzah Burzah approved these changes

@warriorstar-orion warriorstar-orion warriorstar-orion approved these changes

@AffectedArc07 AffectedArc07 AffectedArc07 approved these changes

Assignees

@AffectedArc07 AffectedArc07

Labels
-Status: Awaiting merge This PR is ready for merge Configuration Change This PR changes the game configuration files. Please run via the host. Testmerge Requested This PR has a pending testmerge request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mindflayering when I shouldn't
7 participants
@Contrabang @AffectedArc07 @warriorstar-orion @lewcc @Crazyhair213 @Burzah @ParadiseSS13-Bot