Skip upgrade if target version same #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip re-installing software if target version matches with installed version on firewall. This also allows upgrading a partially upgraded HA pair if upgrade playbook failed after upgrading a peer. Also fixes a bug in FilterAvailableSoftwareImages script where it fails to return newer hotfix versions because of float comparison.
adambaumeister
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip re-installing software if target version matches with installed version on firewall.
Motivation and Context
This allows upgrading a partially upgraded HA pair if upgrade playbook failed after upgrading a peer.
The firewall with lower panos version should be targeted when creating a new device upgrade incident to upgrade a partially upgraded HA pair.
Also fixes #50
How Has This Been Tested?
Tested on vmseries with xsoar 8.
Screenshots (if appropriate)
Types of changes
Checklist