add delay config to parallel evm funnel #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastienGllmt
approved these changes
May 7, 2024
GGAlanSmithee
pushed a commit
to GGAlanSmithee/paima-engine
that referenced
this pull request
May 16, 2024
* add delay setting for ParallelEvmFunnel * small refactor * add confirmationDepth setting too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a delay setting to the parallel evm funnel, like the mina and carp funnel have. This allows running a chain with probabilistic finality. Technically both
delayandconfirmationDepthare optional, although most likely any setup will need both. By default both are 0, so it's assumed that there won't be rollbacks.