Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ssh-agent requirement by using https to clone docs #347

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

SpaceManiac
Copy link
Contributor

The ssh-agent is only needed because the build process uses SSH to clone GitHub repos. Because these are public repos, we can use HTTPS instead of SSH and bypass this requirement entirely. Now the build will hang neither at the beginning nor the end.

Also cp -f will allow the paima-engine-linux binary to be replaced on the filesystem even if it's currently running (usually not an issue, I assume Node mmaps it or something).

Copy link
Contributor

@SebastienGllmt SebastienGllmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we used to copy private repos and I've been trying to slowly inline everything into this monorepo. I'd like to get the docs in this repo someday to avoid the current awkward work to try and make the docs update at the same time as the code and be properly versioned. Maybe someday

@SebastienGllmt SebastienGllmt merged commit 9779de5 into master Apr 17, 2024
@SpaceManiac SpaceManiac deleted the patch/no-build-ssh branch April 17, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants