Fix ssh-agent requirement by using https to clone docs #347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ssh-agent is only needed because the build process uses SSH to clone GitHub repos. Because these are public repos, we can use HTTPS instead of SSH and bypass this requirement entirely. Now the build will hang neither at the beginning nor the end.
Also
cp -f
will allow thepaima-engine-linux
binary to be replaced on the filesystem even if it's currently running (usually not an issue, I assume Node mmaps it or something).