-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mina funnel #343
Merged
Merged
mina funnel #343
Changes from 26 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
d6cf581
mina funnel: wip
ecioppettini 380eccc
wip
ecioppettini c6110ee
add actions fetching
ecioppettini 09d5ad2
cleanup some lints
ecioppettini f6e8914
split actions and events into 2 cdes
ecioppettini 7fc458c
add after/cursor argument to the queries
ecioppettini cba5de1
remove some debugging logs
ecioppettini ed6fa32
rename cardano cursors table to generic cursor based pagination
ecioppettini d3a63e9
add paginationLimit setting
ecioppettini 6a18c16
dehardcode slot duration
ecioppettini ccdc0fc
replace the node's graphql api with direct db queries
ecioppettini 1743988
replace the archive's graphql with direct db queries
ecioppettini a6f9155
add limit to the query
ecioppettini 5a08d13
add loop to wait for finality
ecioppettini 57af769
remove debugging logs
ecioppettini 92e7e59
minor refactors
ecioppettini c1c0f46
remove unused fields from query
ecioppettini 19e36a6
handle edge case for the cde generic handler
ecioppettini 4c70366
fix upper range querying extra data
ecioppettini c8f2f96
find confirmed timestamp directly instead of getting the slot first
ecioppettini 5060bca
rename the common paginated handling cde function
ecioppettini 02aaa39
small refactor in funnel cursors filtering
ecioppettini 6d54ea1
rework the timestamp to block mapping to not use slots
ecioppettini 5e3ce4f
replace startSlot for startBlockHeight in the extensions
ecioppettini f62b086
add timestamp checkpointing event
ecioppettini 88acf1c
genesisTime field is not used anymore
ecioppettini 3ef89e8
fix missing cache update of the lower bound
ecioppettini 24546d0
allow overriding archive's confirmation parameters
ecioppettini 27dbb08
migrated from postgres to pg
ecioppettini 26e543e
remove debugging logs
ecioppettini 9c65d86
cleanup
ecioppettini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we use the
pg
/pg-tx
libraries we already use?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I just didn't think about it. I started with this dep because it was being used in the archive node api, and since I took that as the base it was simpler to get started. Then I was considering porting to pgtyped eventually, but I didn't think about that. Switching to pg should be simple, I'll do that first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think switching to
pgtyped
is a lower priority. If we can at least usepg
to avoid having to depend on thepostgres
package as well I think that's good enough