cardano transfer: narrow credential relation filter #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
28
to
34
| const relationFilter = | ||
| RelationFilterType.Output | | ||
| RelationFilterType.Input | | ||
| RelationFilterType.StakeRegistration | | ||
| RelationFilterType.StakeDeregistration | | ||
| RelationFilterType.StakeDelegation | | ||
| RelationFilterType.Withdrawal; |
There was a problem hiding this comment.
Hmm, this way is possible I guess, but we'd have to be clear in the docs that users have to manually parse the transaction to know if the address appears in
- ins:
Input,Withdrawal - certs (arguably an ins type):
StakeRegistration,StakeDeregistration,StakeDelegation - outs:
Output
since right now the CDE only gives you access to the Input and Output cases
There was a problem hiding this comment.
I can't think of a particular nice way to do this other than to include the tx cbor as well (as mentioned originally here: #262), but even tx cbor is not enough for everything (ex: it doesn't give you the datum for the tx)
There was a problem hiding this comment.
Also I just realized we can replace all input types with TxCredentialRelationValue.Witness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #325