Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix batch posting and improve performance #247

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Fix batch posting and improve performance #247

merged 1 commit into from
Oct 26, 2023

Conversation

SebastienGllmt
Copy link
Contributor

@SebastienGllmt SebastienGllmt commented Oct 26, 2023 •
edited
Loading

Bug fixes

  • When using emulated blocks, if a chain took too longer (longer than 8 seconds) for a transaction to appear on chain, it would fail (even if EMULATED_BLOCKS_MAX_WAIT is set to a higher value)
  • Fix emulated blocks sometimes not creating a block even though they should be able to (result is the same, but this fix should make it go a bit faster)

Other changes

  • Improved logging for emulated blocks so it's easier to know which blocks correspond to which timestamp ranges

@SebastienGllmt SebastienGllmt added the bug Something isn't working label Oct 26, 2023
@SebastienGllmt SebastienGllmt self-assigned this Oct 26, 2023
@SebastienGllmt SebastienGllmt merged commit 058f1e4 into master Oct 26, 2023
@SebastienGllmt SebastienGllmt deleted the fix-batch-posting branch October 26, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SebastienGllmt SebastienGllmt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SebastienGllmt