Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erc6551 CDE support in Paima Engine #236

Merged
merged 13 commits into from
Oct 24, 2023
Merged

Erc6551 CDE support in Paima Engine #236

merged 13 commits into from
Oct 24, 2023

Conversation

SebastienGllmt
Copy link
Contributor

@SebastienGllmt SebastienGllmt commented Oct 15, 2023

This adds ERC6551 support in Paima Engine

Changes in this PR

Other than the ERC6551 feature (you can find the docs for it here, I also made the following changes:

  • Nx added a feature I requested where choosing build parallelism is an ENV var, so I migrated Paima build to NX_PARALLEL
  • Fix an issue where eslint setup wasn't detecting mts files
  • Fix bug where jest tests weren't able to import other packages part of the Paima repo
  • Fix a bug where ERC20Deposit CDE was making more RPC requests than necessary (wasn't filtering on the to field)
  • Changed the CDE config parsing so that types and parsing logic are unified using typebox instead of being duplicated
  • Added a test for CDE config file parsing
  • Simplified logic for testing if CDE configs match what an already populated database used to sync. It now checks the hash of the config instead of having to manually create cache keys to compare if something changed. This allows deleting all the config SQL tables
  • Clarify wording in the contract deploy script
  • Add MIT SPDX headers to Solidity files
  • Fix ERC20 deployment contracts possibly adding null currencies to the list of ERC20 tokens supported for payments
  • Lowered the amount of backend & RPC calls made by games that that call the wallet login method in a loop
  • Fixed connectExternal for wallets re-creating a wallet connection if connecting to the same wallet
  • Improved error message for missing blocks in paima-funnel
  • Updated Web3 provider to easily allow middleware like logging RPC requests by commenting out a few lines

@SebastienGllmt SebastienGllmt self-assigned this Oct 15, 2023
@SebastienGllmt SebastienGllmt merged commit dd6768e into master Oct 24, 2023
@SebastienGllmt SebastienGllmt deleted the erc6551-cde branch October 24, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant