Mint without verification data should not make an external call

PaimaStudios · Apr 2, 2024 · 8f19172 · 8f19172
1 parent 5e6b1ba
commit 8f19172
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/contracts/evm-contracts/contracts/token/InverseAppProjectedNft.sol b/packages/contracts/evm-contracts/contracts/token/InverseAppProjectedNft.sol
@@ -75,7 +75,7 @@ contract InverseAppProjectedNft is IInverseAppProjectedNft, ERC721, Ownable {
     /// Increases the `totalSupply` and `currentTokenId`.
     /// Reverts if `_to` is a zero address or if it refers to smart contract but does not implement IERC721Receiver-onERC721Received.
     /// Emits the `Minted` event.
-    function mint(address _to, bytes calldata _verificationData) public virtual returns (uint256) {
+    function mint(address _to, bytes memory _verificationData) public virtual returns (uint256) {
         require(_to != address(0), "InverseAppProjectedNft: zero receiver address");
         require(
             validateMint(_to, _verificationData),
@@ -96,7 +96,7 @@ contract InverseAppProjectedNft is IInverseAppProjectedNft, ERC721, Ownable {
     }
 
     function mint(address _to) external returns (uint256) {
-        return this.mint(_to, "");
+        return mint(_to, bytes(""));
     }
 
     /// @dev Burns token of ID `_tokenId`. Callable only by the owner of the specified token.

diff --git a/packages/contracts/evm-contracts/test/InverseAppProjectedNft.t.sol b/packages/contracts/evm-contracts/test/InverseAppProjectedNft.t.sol
@@ -42,6 +42,13 @@ contract InverseAppProjectedNftTest is CTest, ERC721Holder {
     }
 
     function test_CanMint() public {
+        vm.prank(alice);
+        vm.expectEmit(true, true, true, true);
+        emit IInverseAppProjectedNft.Minted(2, address(this), 2);
+        nft.mint(address(this), bytes(""));
+    }
+
+    function test_CanMintNoVerificationData() public {
         vm.prank(alice);
         vm.expectEmit(true, true, true, true);
         emit IInverseAppProjectedNft.Minted(2, address(this), 2);