Gcode quality is much improved, update/fix of add_rotation #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checked on gcode emulator and did a dry run.
Checked on gcode emulator and a dry run
Checked by gcode emulator and dry run
Checked by gcode emulator and dry run
Checked by gcode emulator and dry run
Checked by gcode emulator and dry run
Checked by gcode emulator and dry run
Checked by gcode emulator and dry run
Checked by gcode emulator and dry run
Checked by gcode emulator and dry run
Checked by gcode emulator and dry run
Checked by gcode emulator and dry run
Definition and check for machine parameters, tool parameters and configuration.
Added set_machine_parameters, code_initialize, rapid_move, set_laser_mode, set_distance_mode, program_end
GCODE is a modal language and requires only changes of coordinates, speed, power or laser mode to be emitted, this update reflects that. Added rapid_move (G0) and dynamic laser power mode (M4). Added methods code_initialize(self), program_end(self), rapid_move(self, x=None, y=None, z=None), set_distance_mode(self, distance_mode), set_laser_mode(self, mode), set_machine_parameters(self, params).
Override the set_laser_power method, use gcode M7 - mist coolant - instead of M8 - flood coolant . (note that setting 'fan' must be True for this to work)
Rotation must include a center. Verified that translations work correct now.
Note that elliptical arcs are applied correctly! So comment "# Todo transformations aren't applied correctly to elliptical arcs" (_path.py) is incorrect.
A note on comment
# ToDo apply transformation beforehand (in Path) for consistency with other geometric objects. If you (the reader)
# know how to easily apply an affine transformation to an ellipse feel free to make a pull request.
(_elliptical_arc.py): it seems to me that the 'rotation' parameter of the ellipticalarc interferes with a transformation that results in rotation. To get it right the 'rotation' part of the translation must be extracted.
Laser mode is now set correctly.
Added settings for image printing
Added image 'compilation'. Svg 'image' tags are fully supported now.
Added RasterImage class
Adder RasterImage class to handle sag 'image' tags
Added sag 'image' tag handling
Added info on engraving svg image tags and the svg2gcode steering program.
cleanup
Added viewBox (and viewport) notion.
Added viewBox notion.
Image2gcode conversion fix (same pixel line to 'end of line' wasn't drawn in the right color)
Negative viewBox 'x' and 'y' coordinates are recognised now. Fixed viewBox transformation order
fix of absolute_cubic_bezier_extension
MIT license now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCODE is a modal language and requires only changes of coordinates, speed, power or laser mode to be emitted, this update reflects that. Quality of Gcode is much improved and adapted to the latest GRBL.
Updated all test results and checked for correctness, tested (multiple) transformations and checked for correctness.
Rotation must include a center. Verified that transformations work correct now.
Note that elliptical arcs are applied correctly!
Documentation:
Gcode: http://linuxcnc.org/docs/html/gcode/g-code.html
http://linuxcnc.org/docs/html/gcode/other-code.html#sec:set-feed-rate (Gcode parameters)
https://www.cnc4fun.com/wp-content/uploads/2019/12/Grbl-Commands-v1.1-2.pdf (grbl v1.1 commands)
GRBL 1.1: https://github.com/gnea/grbl/releases
laser mode: https://github.com/gnea/grbl/wiki/Grbl-v1.1-Laser-Mode