Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial file sync #1

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Initial file sync #1

merged 4 commits into from
Sep 10, 2024

Conversation

holtjma
Copy link
Collaborator

@holtjma holtjma commented Sep 9, 2024

This is the initial file sync for the waffle_con crate. Things included:

  • License file - PB license file
  • Basic README - I do not think we need to go in depth here, this is just to support StarPhase. Users can run cargo doc if they really want to know more about using it.
  • Source code
  • Test files and GitHub workflow

@ctsa If you can give it a glance through, in particular the README and other user facing materials.

@holtjma holtjma requested a review from ctsa September 9, 2024 13:57
ctsa
ctsa approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@ctsa ctsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the discussion on this yesterday.

@holtjma holtjma merged commit 7997a59 into main Sep 10, 2024
2 checks passed
@holtjma holtjma deleted the initial_pr branch September 10, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctsa ctsa ctsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holtjma @ctsa