Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next minor release. #174

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Next minor release. #174

wants to merge 21 commits into from

Conversation

williamrowell
Copy link
Collaborator

@williamrowell williamrowell commented Dec 9, 2024

  • Support input BAMs without basemods. Reads without basemods will not contribute to basemod pileups.
  • Support input BAMs without rq tags. rq will not be calculated for these reads, but the reads will be aligned for downstream processes.
  • Update to pbmm2 1.16.99 prerelease. Fixes behavior where SA tags were not stripped from aligned input.
  • Updated to TRGT v1.4.1.
    • Increased memory for trgt task to better support larger catalogs with lower complexity motifs.
    • Added the max_depth parameter and limited to 50 to reduce memory usage for high depth low complexity loci.
    • Reduced the number of samtools sort threads to lower total memory used for sort.
  • Remove StarPhase outputs that are not allowed as PharmCAT input (Feature request: PharmCAT accepts no-call result from outside call file PharmGKB/PharmCAT#204)
    • NO_READS is used in StarPhase output to indicate no-calls.
    • NO_MATCH is used when StarPhase can't match the variants to a known allele.
    • This workaround removes NO_READS/NO_MATCH outputs.
  • Only attempt to run PharmCAT if at least one PharmCAT region has depth > pharmcat_min_coverage

@williamrowell williamrowell self-assigned this Dec 9, 2024
Copy link
Contributor

@juniper-lake juniper-lake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks right to me

@williamrowell williamrowell changed the title Support for BAMs that lack basemods. Support a larger variety of input BAMs. Dec 9, 2024
@williamrowell williamrowell marked this pull request as ready for review December 17, 2024 23:07
@williamrowell williamrowell changed the title Support a larger variety of input BAMs. Next minor release. Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants