Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

citra_qt: win32 fix ffmpeg missing files. #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kongfl888
Copy link
Contributor

@kongfl888 kongfl888 commented Oct 13, 2024

Closed #249 , and fixed the missing files mentioned in #274 .

The previous ffmpeg libraries were all copied by Qt. Obviously, Qt does not require complete library files.
Now, they come from the latest version of https://github.com/kongfl888/FFmpeg-Builds/releases.
It contains configurations sourced from Qt. And it reduces the filesizes, compared to the parent project which is recommended by ffmpeg org.

Now using Actions to compile the Android version may result in errors. But the modifications here will not affect non Windows users. Please refer to #275

@PabloMK7
Copy link
Owner

PabloMK7 commented Oct 23, 2024

Hello.
Sorry but I can't trust packages coming directly from the releases of projects hosted by other users.
It poses a security risk if the account is compromised and the packages are updated without nobody noticing.

Are there other solutions?

@kongfl888
Copy link
Contributor Author

Hello. Sorry but I can't trust packages coming directly from the releases of projects hosted by other users. It poses a security risk if the account is compromised and the packages are updated without nobody noticing.

Are there other solutions?

Thank you.
What about using your fork, maybe it can better control the version.
After forking, please update this code: FFmpeg-Builds:util/vars.sh:L33
Moreover, the ffmpeg here does not require frequent updates. Keeping a currently available version is also a good idea.
So we can also use a new repository provided by you for downloading, and upload a valid version such as this ffmpeg-n7.1-latest-win64-gpl-shared-7.1.zip to the Releases of this new repository or to this new repository.
Anyway, we need to fix the existing issues.

Have a good day.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Citra failed to dump video.
2 participants